Add grpc package (v1.83.0) by lrishi · Pull Request #555 · gominimal/pkgs

lrishi · 2026-08-02T17:08:23Z

Summary

Adds a new package for grpc (gRPC Core), a high-performance, open-source universal RPC framework. This allows downstream C++ projects (and other languages) in the Minimal ecosystem to consume gRPC and its plugins natively.

Changes

Added new package grpc.
Upstream Version: 1.83.0
Source URL: https://github.com/grpc/grpc/archive/refs/tags/v1.83.0.tar.gz
Wires in existing Minimal packages (abseil-cpp, protobuf, c-ares, openssl, re2, zlib) via CMake package providers (-DgRPC_*_PROVIDER=package).
Sets BUILD_SHARED_LIBS=ON and CMAKE_INSTALL_LIBDIR=/usr/lib to consistently emit .so artifacts alongside standard CMake/pkgconfig data.
Registers standard C++ runtime dependencies (glibc and gcc subsets for libgcc/libstdcpp) so downstream consumers can successfully link and load the shared libraries.

Checklist

I've read CONTRIBUTING.md.
I've accepted the ICLA (and CCLA if contributing on my employer's time). CLA Assistant will prompt me on this PR if I haven't already.
min check passes for the affected packages/harnesses.
min patched-build <name> succeeds for any package I added or modified.
For new packages: source_provenance points to the canonical upstream and the source builds from source (not a prebuilt release binary) where the required toolchain is available.
For version bumps: I've verified the new sha256 against the upstream archive.

Notes for reviewers

Summary by CodeRabbit

New Features
- Added support for gRPC version 1.83.0.
- Provides gRPC binaries, shared libraries, headers, CMake configuration, and pkg-config metadata.
- Includes certificate-root files for secure connections.
- Supports optimized shared-library builds with system dependencies and staged installation.
- Includes verified source provenance information for improved package traceability.
- Validates library linking, plugin availability, and Protocol Buffers compilation across supported language plugins.

CLAassistant · 2026-08-02T17:08:30Z

All committers have signed the CLA.

coderabbitai · 2026-08-02T17:08:39Z

📝 Walkthrough

Walkthrough

Adds a gRPC 1.83.0 package definition. The package fetches a verified GitHub archive, declares dependencies and outputs, builds with CMake into $OUTPUT_DIR, and validates linking, plugins, and proto compilation.

Changes

gRPC package

Layer / File(s)	Summary
Package contract and source definition `packages/grpc/build.ncl`	Defines the gRPC version, verified source archive, build and runtime dependencies, package outputs, GitHub provenance metadata, and build specification.
Build and staged installation `packages/grpc/build.sh`	Configures CMake with release flags, packaged dependencies, shared-library installation, disabled tests, parallel compilation, and staged installation into `$OUTPUT_DIR`.
Package integration tests `packages/grpc/build.ncl`	Tests gRPC linking, language-specific plugin availability, and protobuf and gRPC C++ generation for multiple plugins.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant BuildSpec
  participant build.sh
  participant CMake
  participant OUTPUT_DIR
  participant PackageTests
  BuildSpec->>build.sh: pass package version
  build.sh->>CMake: configure gRPC with packaged dependencies
  CMake->>CMake: compile shared libraries
  CMake->>OUTPUT_DIR: install package outputs
  PackageTests->>OUTPUT_DIR: link against gRPC and run plugin and proto checks

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding the gRPC package at version 1.83.0.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

packages/grpc/build.sh (1)
1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use the repository shell convention.

Use #!/bin/sh and set -e. This script does not use Bash-specific syntax.
Proposed fix
-#!/bin/bash
-set -euo pipefail
+#!/bin/sh
+set -e
Based on learnings, packages/*/build.sh scripts use #!/bin/sh and set -e; individual packages must not switch to Bash strict mode.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/grpc/build.sh` around lines 1 - 2, Update the
`packages/grpc/build.sh` shell setup to use the repository convention: replace
the Bash shebang with `#!/bin/sh` and use `set -e` instead of `set -euo
pipefail`, preserving the script’s existing commands.
Source: Learnings

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/grpc/build.ncl`:
- Around line 1-10: Update the import bindings in the minimal.ncl destructuring
so lowercase identifiers come first in alphabetical order, followed by
alphabetized uppercase identifiers; specifically place gcc before glibc and
order BuildSpec, Local, OutputBin, OutputData, OutputLib, Source, and Test
accordingly.
- Around line 58-64: Update the outputs declaration to explicitly capture gRPC’s
installed root certificate at usr/share/grpc/etc/roots.pem, using the
appropriate OutputData type alongside the existing bins, libs, headers, cmake,
and pkgconfig outputs.

In `@packages/grpc/build.sh`:
- Around line 10-23: Update the cmake configuration in build.sh to disable
gRPC’s implicit archive downloads while retaining the existing
gRPC_*_PROVIDER=package settings and GitHub tag archive behavior. Add the
appropriate gRPC CMake option alongside the other gRPC configuration flags.

---

Nitpick comments:
In `@packages/grpc/build.sh`:
- Around line 1-2: Update the `packages/grpc/build.sh` shell setup to use the
repository convention: replace the Bash shebang with `#!/bin/sh` and use `set
-e` instead of `set -euo pipefail`, preserving the script’s existing commands.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 32cbc01e-1a4f-4396-a113-066aaff4b61b

📥 Commits

Reviewing files that changed from the base of the PR and between 527251f and fc6dc87.

📒 Files selected for processing (2)

packages/grpc/build.ncl
packages/grpc/build.sh

msample · 2026-08-02T17:44:40Z

/build

msample · 2026-08-02T18:26:26Z

/build

msample · 2026-08-02T18:48:10Z

Lovel, do you have time to add an exec test for each executable this package produces? For example, see what we do for jq - https://github.com/gominimal/pkgs/blob/main/packages/jq/build.ncl

This makes catching issues easier when we bump up the src version in the future.

lrishi · 2026-08-02T19:11:09Z

Lovel, do you have time to add an exec test for each executable this package produces? For example, see what we do for jq - https://github.com/gominimal/pkgs/blob/main/packages/jq/build.ncl

This makes catching issues easier when we bump up the src version in the future.

Yes, I'll add it.

twitchyliquid64 · 2026-08-02T20:44:43Z

/build

twitchyliquid64 · 2026-08-02T21:00:48Z

Run min check --fix - package build.ncl just needs formatting

msample · 2026-08-02T21:25:04Z

/build

msample

LGTM. Thanks Lovel!

Add grpc package (v1.83.0)

fc6dc87

coderabbitai Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread packages/grpc/build.ncl Outdated

Comment thread packages/grpc/build.ncl

Comment thread packages/grpc/build.sh

apply fixes for coderabbit comments

e1a1e70

msample reviewed Aug 2, 2026

View reviewed changes

Comment thread packages/grpc/build.ncl

Remove Test

e1cd3e3

Add proto grpc compilation tests

32c22df

Fix lint errors

521ec80

msample approved these changes Aug 2, 2026

View reviewed changes

msample added this pull request to the merge queue Aug 2, 2026

Merged via the queue into gominimal:main with commit 6798bfc Aug 2, 2026
10 checks passed

Uh oh!

Conversation

lrishi commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Checklist

Notes for reviewers

Summary by CodeRabbit

Uh oh!

CLAassistant commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msample commented Aug 2, 2026

Uh oh!

Uh oh!

msample commented Aug 2, 2026

Uh oh!

msample commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lrishi commented Aug 2, 2026

Uh oh!

twitchyliquid64 commented Aug 2, 2026

Uh oh!

twitchyliquid64 commented Aug 2, 2026

Uh oh!

msample commented Aug 2, 2026

Uh oh!

msample left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lrishi commented Aug 2, 2026 •

edited

Loading

CLAassistant commented Aug 2, 2026 •

edited

Loading

coderabbitai Bot commented Aug 2, 2026 •

edited

Loading

msample commented Aug 2, 2026 •

edited

Loading