Skip to content

fix(ghc): reduce build time with parallelism - #575

Merged
twitchyliquid64 merged 3 commits into
mainfrom
tom/ghc
Aug 6, 2026
Merged

fix(ghc): reduce build time with parallelism#575
twitchyliquid64 merged 3 commits into
mainfrom
tom/ghc

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Use same flags for build and install, so the version that was built is the one called for in the install (previously we were doing a build and then throwing it away)
  • Set -j $(nprocs)

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The GHC build script defines shared Hadrian flags for parallel execution, the default flavour, and disabled documentation generation. Both build and install use these flags while preserving the install prefix.

Changes

GHC build configuration

Layer / File(s) Summary
Shared Hadrian invocation flags
packages/ghc/build.sh		 The script centralizes -j$(nproc), --flavour=default, and --docs=none in HADRIAN_FLAGS. Build and install use the same flags.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: lrishi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: reducing GHC build time through parallel build flags.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/ghc

Comment @coderabbitai help to get the list of available commands.

bryan-minimal
bryan-minimal approved these changes Aug 6, 2026
View reviewed changes

@bryan-minimal bryan-minimal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into main with commit 85e65c3 Aug 6, 2026
9 of 10 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/ghc branch August 6, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryan-minimal bryan-minimal bryan-minimal approved these changes
@0chroma 0chroma Awaiting requested review from 0chroma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @bryan-minimal