fix(modeling): resolve in-document JSON Schema $ref paths before Pydantic model creation - #85
Open
syf2211 wants to merge 1 commit into
Open
fix(modeling): resolve in-document JSON Schema $ref paths before Pydantic model creation#85syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
…ntic model creation Use jsonref.replace_refs with proxies=False so property-path refs like #/properties/.../request are inlined before create_model_from_json_schema runs. Fixes grll#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve in-document JSON Schema
$refpointers (including#/properties/...paths) before building Pydantic models for CrewAI tools.Motivation
Fixes #75
resolve_refs_and_remove_defsonly inlined#/$defs/...references. Schemas that reference sibling properties (e.g.#/properties/requestResponse/properties/request) were passed through unchanged, causingKeyErrorwhenmodel_json_schema()ran inCrewAIAdapter._generate_description.Changes
$defs-only resolver withjsonref.replace_refs(..., proxies=False)and strip top-level$defs$refschemas from the issue reportTests
2 passed.
Notes
jsonrefdependency already used by other adapters (langchain, smolagents, google-genai)