fix(smolagents): support MCP tools with no input parameters - #86
Open
syf2211 wants to merge 1 commit into
Open
Conversation
Parameter-less tools may expose a valid JSON Schema of {"type": "object"}
without a properties field. SmolAgentsAdapter previously assumed properties
was always present and raised KeyError during adaptation.
Fixes grll#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
SmolAgentsAdaptercrashing when adapting MCP tools whoseinputSchemais a valid empty object schema ({"type": "object"}) without apropertiesfield.Motivation
Some MCP servers expose parameter-less tools (for example, a server version probe). JSON Schema allows omitting
propertiesfor object schemas with no fields, but the adapter accessedinput_schema["properties"]unconditionally and raisedKeyError.Fixes #78
Changes
propertiesas an empty dict viainput_schema.setdefault("properties", {})propertiesmapping when constructing the SmolAgents tool inputsTests
uv run pytest tests/test_smolagents_adapter.py::test_tool_with_no_input_parameters -q— passeduv run pytest tests/test_smolagents_adapter.py -q— 10 passedNotes
properties