CI test: Fix multiple black executables causing admin_scripts to fail - #1
Open
h4l wants to merge 1 commit into
Open
CI test: Fix multiple black executables causing admin_scripts to fail#1h4l wants to merge 1 commit into
h4l wants to merge 1 commit into
Conversation
h4l
force-pushed
the
fix-multiple-formatter-executables-admin-scripts-test
branch
from
November 4, 2025 08:31
1825033 to
ceea243
Compare
The fix for bug #36680 removed the PATH entry containing the black found by `find_formatters()`, but when black exists on the PATH in more than one location, `find_formatters()` would still find and run black during the tests, which caused some admin_scripts tests to still fail. The PATH is now pre-processed to remove all dirs containing black, not just the primary dir.
h4l
force-pushed
the
fix-multiple-formatter-executables-admin-scripts-test
branch
from
November 4, 2025 08:40
ceea243 to
005ca54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for bug #36680 removed the PATH entry containing the black found by
find_formatters(), but when black exists on the PATH in more than one location,find_formatters()would still find and run black during the tests, which caused some admin_scripts tests to still fail.The PATH is now pre-processed to remove all dirs containing black, not just the primary dir.
Trac ticket number
ticket-XXXXX
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist
mainbranch.