#20: align catalogue smell titles with docs/smell-vocabulary.md#29
Merged
Conversation
Reconcile the four drifted titles (var-declaration, warning-comment, explicit-any, non-essential-comment) with the canonical vocabulary table. Content-only; no behavioural change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nq6xHU6JtSNpYWhMYjXB15
Parse the docs/smell-vocabulary.md catalogue table and assert every defaultRules title matches, so future drift fails the suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nq6xHU6JtSNpYWhMYjXB15
devill
marked this pull request as ready for review
June 17, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
Phase 1 copied catalogue titles verbatim from the old tool-keyed rules and deferred aligning them with the canonical
docs/smell-vocabulary.mdtable. This reconciles them.Changes (atomic commits)
#20: align catalogue titles with docs/smell-vocabulary.md— fixes the four drifted titles, content-only, no behavioural change:var-declaration:var declaration→`var` declarationwarning-comment:Warning comment→Warning comment (TODO/FIXME/…)explicit-any:Explicit any→Explicit `any`non-essential-comment:Comment found→Non-essential comment#20: gate catalogue titles against the vocabulary doc— parses the doc's Catalogue table and asserts everydefaultRulestitle matches, so future drift fails the suite.Notes
severity/id/source/changedFilesOnlyfields touched — title-only.Gates
pnpm build,pnpm lint— cleanpnpm test— 386 passed (+1 new gate)🤖 Generated with Claude Code
Generated by Claude Code