#18: implement the guide command fix action#32
Merged
Conversation
Optional stdin option, written and closed after spawn (with an error listener so a child that never reads stdin can't raise EPIPE). Existing callers are unaffected when stdin is unset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nq6xHU6JtSNpYWhMYjXB15
runFixCommand spawns the smell's script with its bag as JSON on stdin. A spawn/timeout failure is a blocking config error (always blocks); a clean non-zero exit blocks only an enforced smell; exit 0 never blocks. The script's stdout/stderr is returned for display to the agent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nq6xHU6JtSNpYWhMYjXB15
issues), streams the script output into the smell's section, and folds its exit code into the run's exit code. prompt behaviour is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nq6xHU6JtSNpYWhMYjXB15
devill
force-pushed
the
issue-18-command-fix
branch
from
June 17, 2026 14:51
3dd537b to
8a4ce16
Compare
devill
marked this pull request as ready for review
June 17, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
Only the
promptfix action was implemented; acommandaction rendered nothing. This runs the script perdocs/guide.md: the smell's whole bag as JSON on stdin, once per smell, stdout/stderr streamed to the agent, exit code folded into the run's exit code.Locked decisions
Exit folding per the docs table: command exit 0 never blocks (even for an
enforcedsmell — it overrides the default "enforced + issues = 1" rule); non-zero blocks only anenforcedsmell.promptbehaviour is unchanged.Atomic commits
#18: let runTool write stdin to the spawned process— optionalstdinwith an EPIPE guard; existing callers unaffected.#18: add the command fix runner—runFixCommand+ unit tests (exit 0 / non-zero / enforced vs suggested / spawn-failure).#18: run command fix actions from the guide— guide becomes async, runs each command action, streams output into the section, folds the exit code; runner threadscwdand awaits.Gates
pnpm build,pnpm lint— clean (all functions within max-lines/max-params)pnpm test— 392 passed (+7)🤖 Generated with Claude Code
Generated by Claude Code