Fall back bool/int64/uint64/float64 to supported dtypes with a warning - #6
Open
haesleinhuepf with Copilot wants to merge 2 commits into
Open
Fall back bool/int64/uint64/float64 to supported dtypes with a warning#6haesleinhuepf with Copilot wants to merge 2 commits into
haesleinhuepf with Copilot wants to merge 2 commits into
Conversation
bool→int8, int64→int32, uint64→uint32, float64→float32. require_supported() now emits a UserWarning instead of raising TypeError. _from_host() casts the host array to the fallback dtype before pushing. Update test to verify warning and fallback dtype rather than rejection.
Copilot
AI
changed the title
[WIP] Support array API bool, float64, int64, and uint64 dtypes in pyclesperanto
Fall back bool/int64/uint64/float64 to supported dtypes with a warning
Jun 20, 2026
haesleinhuepf
marked this pull request as ready for review
June 20, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyclesperantodoesn't natively supportbool,int64,uint64, orfloat64. Previously, passing these dtypes raisedTypeError, breaking Array API compliance. Per maintainer guidance, the fix is a silent-downcast-with-warning strategy rather than hard rejection.Changes
_dtypes.py— addsDTYPE_FALLBACKSmapping unsupported → nearest supported dtype (bool→int8,int64→int32,uint64→uint32,float64→float32).require_supported()now emits aUserWarningand returns the fallback instead of raising.__init__.py/_from_host()— casts the host NumPy array to the resolved dtype before the device push, so the buffer type matches when the backend ignores thedtypekwarg.test_creation.py— replaces the "rejects unsupported dtype" test with one that asserts the warning is emitted and the array carries the fallback dtype.