MM-010 add layered live doctor diagnostics - #9
Draft
himattm wants to merge 1 commit into
Draft
Conversation
Reproduction: plain doctor could pass installation and graph checks even though the foreground app was wrong or Android CLI could not capture under the active filesystem permissions. Add doctor --live to verify the selected device identity, expected foreground package, and one minimal normalized layout capture. Stop at the failing layer and emit distinct device, app mismatch, analytics spool, or capture diagnostics with concise remediation and optional verbose subprocess detail. Verified with healthy, no-device, wrong-app, restricted-analytics, and verbose contracts; all existing doctor tests; a live API 36 GetGoing probe with 56 elements; cargo test --workspace; Clippy with warnings denied; formatting checks; and the minimap binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add read-only
doctor --livediagnostics that verify the selected device identity, expected foreground package, and one minimal normalized layout capture. Failures are separated into repository/config, device, app mismatch, analytics permission, and general capture layers, each with targeted remediation and optional verbose subprocess detail.Why
Plain doctor could pass installation and graph checks while the wrong app was foreground or Android CLI could not capture under current filesystem permissions.
Impact
Developers can distinguish the failing layer before attempting navigation, while plain
doctorremains a non-capturing configuration check.Validation
Stack
Depends on #8; base branch:
agent/mm-008-report-device-identity.