Skip to content

refactor(eval): park experimental eval-harness behind opt-in feature - #2

Merged
hoainho merged 1 commit into
janusfrom
feature/park-eval-harness
Jul 11, 2026
Merged

refactor(eval): park experimental eval-harness behind opt-in feature#2
hoainho merged 1 commit into
janusfrom
feature/park-eval-harness

Conversation

@hoainho

@hoainho hoainho commented Jul 11, 2026

Copy link
Copy Markdown
Owner

What

The eval-harness (~2000 LOC) is unused (0 rows in DB) yet advertised as a headline feature. This gates it behind an opt-in cargo feature so the default build excludes it, removing maintenance/confusion debt while keeping the code.

  • crates/harness-cli/Cargo.toml: added [features] eval = [] (not in default).
  • #[cfg(feature = "eval")] on: mod eval, Command::Eval, its dispatch arm, all 16 Eval* arg structs + EvalAction, the 14 run_* fns, 3 eval-only helpers, and eval-only imports.
  • README + EVAL_HARNESS_README: reframed eval as experimental / --features eval opt-in.

Verify (all exit 0, -D warnings)

  • default: cargo build/clippy --release — eval subcommand ABSENT.
  • feature: cargo build/clippy --release --features eval — eval subcommand PRESENT.

Commit

  • f2209d6 refactor(eval): gate experimental eval-harness behind opt-in cargo feature

…ature

Default build no longer compiles the ~2000-LOC eval layer; enable with --features eval.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an experimental, opt-in eval Cargo feature to gate the eval-harness functionality (including the eval module, associated CLI commands, and helper functions) in the harness-cli crate. The documentation in README.md and EVAL_HARNESS_README.md has been updated to reflect that these commands are no longer included in the default binary and must be built with --features eval. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@hoainho
hoainho merged commit 5801744 into janus Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant