refactor(dev): babysit-prs — progressive disclosure into references/ - #11
Merged
Conversation
Point 2 of the babysit-prs improvement plan: progressive disclosure. The two
long per-PR procedures move out of SKILL.md into one file per axis under
references/, leaving SKILL.md at 311 lines (was 574).
- references/conflict-procedure.md — the merge-conflict axis (steps 1-7)
- references/ci-procedure.md — the failing-checks axis (steps 1-5)
Both bodies move verbatim; the only text changes are cross-references that no
longer resolve in-file ("step 5" -> "step 5 below", and CI step 4's pointer at
the conflict procedure's own step 7). Each file opens by naming its worktree dir
and its placeholders, and defers to SKILL.md for the confidence rule and Safety
so neither is duplicated.
Wiring:
- Step 1 resolves SKILL_DIR alongside SKILL_FILE and states that the
orchestrator must not read either procedure file — it only passes the paths on.
- The Step 4 worker prompt carries a procedure path per flagged axis, with an
explicit instruction to read only the flagged ones, as each axis is reached.
- The inline (no Agent tool) fallback is called out as the one path that reads
the procedure files itself.
Frontmatter description is unchanged, so the generated README is untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements point 2 of the babysit-prs improvement plan: progressive disclosure. The two long per-PR procedures move out of
SKILL.mdinto one reference file per axis.Stacked on
babysit-prs-skill(point 1, #10).What changed
SKILL.mdgoes 574 → 311 lines. The orchestrator half, the worker contract (routing table + confidence rule) andSafetystay; the procedures leave:references/conflict-procedure.md— the merge-conflict axis, steps 1–7references/ci-procedure.md— the failing-checks axis, steps 1–5Both bodies moved verbatim. The only text changes are the three cross-references that stopped resolving in-file:
"(step 5)"→"(step 5 below)","Step 5 asserts"→"Step 5 below asserts", and CI step 4's mention of the conflict procedure now naming the file plus its own step 7. Verified mechanically by diffing the old sections against the new files (164→164 and 77→78 non-blank lines, 3 hunks, all three of them the above).Each reference file opens with a short header instead of duplicating shared rules: what axis it is, which
WORKTREE_DIRliteral it means, that<...>values come from the worker prompt, that its step numbers are its own (not the orchestrator's Steps 1–5), and a pointer back to../SKILL.mdfor the confidence rule and Safety. The conflict file ends by handing off to the CI file when both axes are flagged.Wiring
SKILL_DIRnext toSKILL_FILE, tables the two procedure paths, and says explicitly that the orchestrator must not read them — it only passes the paths on. That's where the win lands: ~300 lines of git surgery and CI archaeology never enter a context that, under/loop, accumulates pass after pass.Procedure:path per flagged axis (absolute, literal — same rule as every other value in that template), with an instruction to read only the flagged ones and only on reaching that axis. A conflicts-only worker never loads the CI procedure.Verification
#conflict-procedure/#ci-procedureanchor links anywhere in the repo.grep -iE 'hoopit|BAC-|WEB-|FA-'clean across the skill dir — repo-agnostic per create-hoopit-skill Rule 1.descriptionunchanged;scripts/gen-skills-readme.shregeneratesREADME.mdwith no diff (pre-commitpasses).Not in this PR
Later points of the plan: flake retry, cross-pass state, stale-worktree sweep.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.