Draft
Fix query result decoding - decode binary packets into structured data#2
Conversation
Co-authored-by: id <138221+id@users.noreply.github.com>
Co-authored-by: id <138221+id@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Query result is not decoded
Fix query result decoding - decode binary packets into structured data
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Query results were returned as raw binary packets, making the library difficult to use:
Users had to understand ClickHouse protocol internals to decode these packets, which created a poor developer experience.
Solution
Implemented automatic query result decoding that transforms binary packets into structured, user-friendly data:
Changes Made
Core Implementation
decode_query_result/1inclicker_protocol.erl- Main decoder that handles multiple packet typesdecode_data_packet/1- Extracts column/row information from data blocksdecode_exception_packet/1- Parses error details (code, message, stack trace)decode_progress_packet/1- Extracts query progress informationclicker_conn.erlto automatically decode responsesSupported Packet Types
Examples
Testing
Benefits
Fixes #1.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)repo.hex.pm/usr/lib/erlang/erts-13.2.2.5/bin/inet_gethost 4(dns block)s3.amazonaws.comcurl -skfL REDACTED -o /home/REDACTED/work/clicker/clicker/rebar3(dns block)curl -skfL REDACTED -o rebar3(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.