Add CommandError helper, Go 1.25, and linting improvements#4
Open
dustinblack wants to merge 5 commits into
Open
Add CommandError helper, Go 1.25, and linting improvements#4dustinblack wants to merge 5 commits into
dustinblack wants to merge 5 commits into
Conversation
- Add standard Go .gitignore - Fix package doc comment to use 'Package exex' convention - Add trailing periods to doc comments for godot compliance Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Update Go version from 1.17 to 1.25 - Add .golangci.yaml with comprehensive linter configuration (v2 format) - Add //nolint:gosec annotations on Command and CommandContext for intentional variable argument execution Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandError(err, errMsg)function that returns a formatted error with stderr output appended when the error is an*exec.ExitError.golangci.yamlwith comprehensive linter configuration (golangci-lint v2 format).gitignorefor standard Go build artifacts//nolint:gosecannotations onCommandandCommandContextfor intentional variable argument executionDetails
CommandErrorhelperA convenience function for extracting and formatting stderr from failed command executions. Given an error and a message string, it:
niliferrisnil*exec.ExitErrorwith captured stderrDoc comment fixes
Package exexper Go conventionError,ExitError) andString()now end with periodsTest plan
go test ./...)CommandErrorbehavior with nil error, ExitError with stderr, and ExitError without stderr🤖 Generated with Claude Code