Skip to content

fix: use cmd/ctrl+enter to open search result in a new tab #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inkless merged 1 commit into from
Jun 9, 2026
Merged

fix: use cmd/ctrl+enter to open search result in a new tab #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions e2e/tests/file-search.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ test.describe("file search", () => {
await expect(page).toHaveURL(/\/README\.md$/);
});

test("Shift+Enter opens the selected file in a new tab, leaving the modal open", async ({
test("Cmd+Enter opens the selected file in a new tab, leaving the modal open", async ({
page,
}) => {
await page.goto("/README.md");
Expand All @@ -79,13 +79,11 @@ test.describe("file search", () => {
const dialog = page.locator("dialog.mdbrowse-search");
const [popup] = await Promise.all([
page.context().waitForEvent("page"),
page.keyboard.press("Shift+Enter"),
page.keyboard.press("Meta+Enter"),
]);

await popup.waitForLoadState();
await expect(popup).toHaveURL(/\/runbooks\/deploy\.md$/);

// Original tab stayed put and the modal is still open for the next pick.
await expect(page).toHaveURL(/\/README\.md$/);
await expect(dialog).toBeVisible();
});
Expand Down
25 changes: 19 additions & 6 deletions src/assets/static/js/file-search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@
moveSelection(-1);
} else if (e.key === "Enter") {
e.preventDefault();
// Shift+Enter opens the result in a new tab and leaves the modal open,
// so you can fan out to several files in one pass.
navigateToSelected(e.shiftKey);
// Cmd/Ctrl+Enter opens the result in a new tab and leaves the modal open,
// so you can fan out to several files in one pass. Mirrors the
// Cmd/Ctrl+Click affordance on result rows (and the new-tab=Cmd/Ctrl
// convention, vs Shift which the browser reads as "new window").
navigateToSelected(e.metaKey || e.ctrlKey);
}
// Escape is handled natively by <dialog>.
});
Expand Down Expand Up @@ -152,8 +154,11 @@

// Navigate to `path`. When `newTab` is truthy, open it in a new tab and keep
// the current page (and the search modal) intact; otherwise replace the
// current page. window.open() here runs synchronously inside a keydown/click
// handler, so it counts as a user gesture and won't trip popup blockers.
// current page. window.open(url, "_blank") opens a tab by default — the only
// modifier that the browser reinterprets as "new window" is Shift, which we
// intentionally don't bind (new-tab is Cmd/Ctrl, matching Cmd/Ctrl+Click).
// Runs synchronously inside the keydown/click handler, so it's a user gesture
// and won't trip popup blockers.
function open(path, newTab) {
if (newTab) window.open(path, "_blank");
else location.assign(path);
Expand Down Expand Up @@ -211,13 +216,21 @@
// Expose for tests.
window.__mdbrowseSearch = { filter: filter, score: score };

// Used only to pick the modifier glyph in the hint (⌘ vs Ctrl).
function isMacLike() {
var p = (navigator.platform || navigator.userAgent || "").toLowerCase();
return p.indexOf("mac") !== -1 || p.indexOf("iphone") !== -1 || p.indexOf("ipad") !== -1;
}

function buildDialog() {
var d = document.createElement("dialog");
d.className = "mdbrowse-search";
d.innerHTML =
'<div class="mdbrowse-search__input-row">' +
'<input class="mdbrowse-search__input" type="text" autocomplete="off" autocapitalize="off" spellcheck="false" placeholder="Type to search files…" aria-label="Search files" />' +
'<span class="mdbrowse-search__hint">⇧↵ new tab · Esc close</span>' +
'<span class="mdbrowse-search__hint">' +
(isMacLike() ? "⌘↵" : "Ctrl+↵") +
" new tab · Esc close</span>" +
"</div>" +
'<ul class="mdbrowse-search__results" role="listbox"></ul>' +
'<div class="mdbrowse-search__empty" hidden>No matches</div>';
Expand Down
Loading