Repository navigation
feat(journey-map): add custom markers and selectable map features - #57
Merged
Merged
Conversation
Keep trackpad pinch independent of ordinary wheel scrolling, support Safari gesture inputs without duplicating touchscreen zoom, and retain the water-layer palette when source features carry identifiers rather than terrain categories. Validation on macOS, Node 24.22.1 and React 19.3.1: node --test packages/inkra/test/travel.test.mjs packages/inkra/test/journey-map-rendering.test.mjs packages/inkra/test/journey-map-annotations.test.mjs 27 passed, zero failed or skipped; travel.test.mjs contributes 13 passed cases. Only node24-react19.3.1 component:travel is eligible for local confirmation. The rendering and annotation tests, React 18 lane and mandatory build/package/ installed-consumer checks remain online. Chrome and WebKit input-path checks also passed locally; branded Safari hardware was not tested and no Safari CI was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JourneyMap now supports application-defined pin icons/images, styled routes, and selectable GeoJSON areas with holes. Route and area selection retain the viewport and provide pointer, keyboard and readable fallback controls.
Trackpad pinch works independently of ordinary wheel scrolling, with a Safari gesture path and no duplicate touchscreen handling. Unclassified water features retain the water-layer palette when source identifiers are present.
Validation
node --test packages/inkra/test/travel.test.mjs packages/inkra/test/journey-map-rendering.test.mjs packages/inkra/test/journey-map-annotations.test.mjs— 27 passed, zero failed/skipped. The exactcomponent:travelgroup accounts for 13 passing cases.component:travelis locally confirmed; other tests, React 18 and mandatory repository/build/package/installed-consumer checks remain online.