Skip to content

feat(journey-map): add custom markers and selectable map features - #57

Merged
NWYLZW merged 2 commits into
mainfrom
feat/map-annotations
Nov 2, 2026
Merged

NWYLZW merged 2 commits into
mainfrom
feat/map-annotations

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

JourneyMap now supports application-defined pin icons/images, styled routes, and selectable GeoJSON areas with holes. Route and area selection retain the viewport and provide pointer, keyboard and readable fallback controls.

Trackpad pinch works independently of ordinary wheel scrolling, with a Safari gesture path and no duplicate touchscreen handling. Unclassified water features retain the water-layer palette when source identifiers are present.

Validation

  • Node 24.22.1 / React 19.3.1 on macOS: node --test packages/inkra/test/travel.test.mjs packages/inkra/test/journey-map-rendering.test.mjs packages/inkra/test/journey-map-annotations.test.mjs — 27 passed, zero failed/skipped. The exact component:travel group accounts for 13 passing cases.
  • Local desktop/narrow Chrome checks covered custom markers, shape selection, polygon holes, unchanged viewport and fixed pin sizes. Chromium native pinch input and WebKit event-path checks covered independent scrolling, pointer anchoring, small deltas, disabled interaction and cleanup. Branded Safari hardware remains unverified; no Safari CI was added.
  • Build/package candidate passed. Only Node 24 component:travel is locally confirmed; other tests, React 18 and mandatory repository/build/package/installed-consumer checks remain online.
{
  "schemaVersion": 1,
  "tested_commit": "a96a3d9906f98d236d50f30ea61666355c2a3643",
  "base_commit": "32ff0f9de159047fdd84d29f73bed7fccc0b4683",
  "local_passed": [
    {
      "group": "component:travel",
      "environments": [
        "node24-react19.3.1"
      ],
      "evidence": "https://github.com/inkrajs/inkra/commit/a96a3d9906f98d236d50f30ea61666355c2a3643",
      "reason": "The committed travel.test.mjs group passed locally on Node 24.22.1 / React 19.3.1; retain every other selected test and the React 18 lane."
    }
  ]
}

Keep trackpad pinch independent of ordinary wheel scrolling, support Safari gesture
inputs without duplicating touchscreen zoom, and retain the water-layer palette
when source features carry identifiers rather than terrain categories.

Validation on macOS, Node 24.22.1 and React 19.3.1:
node --test packages/inkra/test/travel.test.mjs packages/inkra/test/journey-map-rendering.test.mjs packages/inkra/test/journey-map-annotations.test.mjs
27 passed, zero failed or skipped; travel.test.mjs contributes 13 passed cases.
Only node24-react19.3.1 component:travel is eligible for local confirmation.
The rendering and annotation tests, React 18 lane and mandatory build/package/
installed-consumer checks remain online. Chrome and WebKit input-path checks
also passed locally; branded Safari hardware was not tested and no Safari CI
was added.
@NWYLZW
NWYLZW merged commit aa1b53e into main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant