Skip to content

Fix JourneyMap viewport sizing and callbacks after removal - #59

Merged
NWYLZW merged 2 commits into
mainfrom
fix/journeymap-lifecycle-and-height
Nov 2, 2026
Merged

NWYLZW merged 2 commits into
mainfrom
fix/journeymap-lifecycle-and-height

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

JourneyMap now honors finite viewport heights above 800 CSS pixels while keeping its canvas backing stores bounded. It also falls back safely for terrain identifiers such as toString and constructor, ignores delayed pan/trackpad/selection work after removal, and refreshes map ink and the scale when inherited theme styles or classes change.

The 480px default, 240px minimum, focus/zoom defaults and existing public APIs remain unchanged. The scale only writes its inline width when the value changes, preventing its style observer from responding repeatedly to its own updates.

Validation

Tested commit: c77049017b00e3fc7993d6b808849cdb0b32f6a2
Base: 451c57a01eed562c8f0273d6cd1961f41a955a43
Local environment: Node 24.14.1, React / React DOM 19.3.1.

  • npm run build: passed, including TypeScript emit and styles.
  • node --test packages/inkra/test/journey-map-*.test.mjs packages/inkra/test/travel.test.mjs: 36 passed, 0 failed, 0 skipped. This includes the entire travel.test.mjs file.
  • node scripts/check-repository.mjs: passed.
  • node scripts/check-package.mjs: passed; all 455 archive files matched the normally installed package byte-for-byte; lock integrity matched and the installation was not a workspace symlink.
  • The repository's installed-smoke.mjs and installed-types.tsx fixtures passed in an existing installed consumer using React 19.3.1.
  • Candidate SHA-256: 006d9295ddf33377d751472146136d650193b80ff846c38e74ddc0864bc03800 (unpublished build; no package version change).

The first local test run found an incorrect test expectation: unknown land identifiers retain the existing no-extra-paper behavior. The corrected regression compares prototype names with another unknown identifier. The final checks above were rerun after the corrective commit.

React 18, real-browser theme/resize/drag-unmount behavior and physical Safari/touch input have not been tested locally for this head. Mandatory contract checks and all tests outside an accepted, environment-matched local declaration remain enabled in CI.

{
  "schemaVersion": 1,
  "tested_commit": "c77049017b00e3fc7993d6b808849cdb0b32f6a2",
  "base_commit": "451c57a01eed562c8f0273d6cd1961f41a955a43",
  "local_passed": [
    {
      "group": "component:travel",
      "environments": [
        "node24-react19.3.1"
      ],
      "evidence": "https://github.com/inkrajs/inkra/pull/59#validation",
      "reason": "The complete travel.test.mjs file passed on this exact committed head with Node 24.14.1 and React 19.3.1; other tests and environments retain normal CI."
    }
  ]
}

@NWYLZW
NWYLZW merged commit 97eadd8 into main Nov 2, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant