Repository navigation
Fix JourneyMap viewport sizing and callbacks after removal - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JourneyMap now honors finite viewport heights above 800 CSS pixels while keeping its canvas backing stores bounded. It also falls back safely for terrain identifiers such as
toStringandconstructor, ignores delayed pan/trackpad/selection work after removal, and refreshes map ink and the scale when inherited theme styles or classes change.The 480px default, 240px minimum, focus/zoom defaults and existing public APIs remain unchanged. The scale only writes its inline width when the value changes, preventing its style observer from responding repeatedly to its own updates.
Validation
Tested commit:
c77049017b00e3fc7993d6b808849cdb0b32f6a2Base:
451c57a01eed562c8f0273d6cd1961f41a955a43Local environment: Node 24.14.1, React / React DOM 19.3.1.
npm run build: passed, including TypeScript emit and styles.node --test packages/inkra/test/journey-map-*.test.mjs packages/inkra/test/travel.test.mjs: 36 passed, 0 failed, 0 skipped. This includes the entiretravel.test.mjsfile.node scripts/check-repository.mjs: passed.node scripts/check-package.mjs: passed; all 455 archive files matched the normally installed package byte-for-byte; lock integrity matched and the installation was not a workspace symlink.installed-smoke.mjsandinstalled-types.tsxfixtures passed in an existing installed consumer using React 19.3.1.006d9295ddf33377d751472146136d650193b80ff846c38e74ddc0864bc03800(unpublished build; no package version change).The first local test run found an incorrect test expectation: unknown land identifiers retain the existing no-extra-paper behavior. The corrected regression compares prototype names with another unknown identifier. The final checks above were rerun after the corrective commit.
React 18, real-browser theme/resize/drag-unmount behavior and physical Safari/touch input have not been tested locally for this head. Mandatory contract checks and all tests outside an accepted, environment-matched local declaration remain enabled in CI.