Basic Gulp v4 compatibility - #9
Open
Jimbly wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key issues with Gulp v4 are:
gulp.tasknever takes adepsargument (deps are now done viagulp.task('foo', gulp.series('dep', fn)), and all task dependencies must be defined, even if not called in a context (e.g. in the worker process, can't rename a task without also leaving something under the old name (which will never be called) for gulp's validation code to find).This change should keep this module compatible with both Gulp v3 and v4.
After fixing the Gulp v4 issues, adding the one line of
require('gulp-ll').tasks(['eslint'])nearly cut my build times in half, thanks!