Keep marky-markdown and still support Node v4 - #74
Open
billiegoose wants to merge 1 commit into
Open
Conversation
Member
Author
Member
|
atom/node-oniguruma fixed the Node 4 support problem with PR.
EDIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having become intimately familiar with the oniguruma dependency in
marky-markdownwhile working on makingmarky-markdownbrowserify compatible, I just happen to know off the top of my head a hacky workaround.We would need to figure out an alternative code-highlighting solution. (Or port oniguruma to JS and be done with the beast.)