Refactor Hercules into a production-ready 0.9 runtime - #94
Open
jakthom wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator-visible changes
Configuration now requires version: 1 and fails closed on unknown or invalid values. The listener defaults to loopback, DuckDB defaults to in-memory storage, resource budgets are explicit, remote Packages and extensions are denied by default, and Metric Definitions use stricter Prometheus naming and result rules.
New check-config, check, print-effective-config, and package-digest commands support rollout and diagnostics. Metrics scrapes serve the latest complete snapshot and no longer execute SQL.
Failure behavior
Startup compiles configuration and Packages before opening DuckDB, then initializes extensions, macros, Sources, and the initial Metric Snapshot in order. Any startup-phase failure prevents readiness. Later collection failures retain the previous complete snapshot; Source refresh failures retain existing state and back off.
Shutdown disables readiness, cancels worker contexts, drains or force-closes HTTP within the caller deadline, joins workers before closing DuckDB, and supports repeated callers observing the same cleanup.
Compatibility
This is an intentional breaking alpha update from 0.8 to 0.9. Existing deployments must update configuration, Package metadata, extension allowlists, metric names and result layouts, and scrape-freshness alerting. See docs/migrating-to-0.9.md for the migration path.
Validation