Support killing process trees cross-platform - #1
Open
jamilahmadzai wants to merge 2 commits into
Open
Conversation
jamilahmadzai
force-pushed
the
codex/process-tree-21
branch
from
July 23, 2026 20:30
4e22c07 to
29ee3e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
treeoption on macOS and Linux withpidtree, while preserving WindowstaskkillbehaviorforceAfterTimeoutandwaitForExit, including children reparented after their root exitsprocess-existsResolves sindresorhus#21
This also addresses the maintainer feedback on the earlier attempt in #34: it uses
pidtreeinstead oftree-kill, updatesindex.d.ts, and makes the default/tree-disabled regression tests cross-platform so the established Windows behavior is covered whenever the Windows job is enabled.Validation
npm teston Node.js 24: 29/29 tests, XO, andtsdpassnpx --yes node@20 --test: 29/29 tests passnpm pack --dry-rungit diff --checkThis fork-local PR is the review artifact because upstream currently has pull requests disabled. It is ready to transplant or merge if upstream contributions are reopened.