Repository navigation
fix: harden CLI UX, browser crash handling, isolated declarations, and CI sharding - #455
Merged
Merged
Conversation
…d CI sharding Fixes #434 Fixes #444 Fixes #447 Fixes #448 - Rescue sole dash-prefixed query terms (e.g. --mu-surface) in ontology query while preserving flag validation - Fail closed in ingest-css-ds when customProperties is empty and point to --css on designmd extract-tokens - Normalize package.json bin.ui path to dist/cli.js to eliminate npm publish sanitization warnings - Detect signal exits (child.signalCode) immediately in rendered browser-session and probe headless launchability in rendered-tier and a11y tests - Bound memory-autorecord orphan test with .git and extend stack-safety test timeout for 2-vCPU CI runners - Enable declarationMap and isolatedDeclarations in tsconfig.dts.json across the ease-design/lint boundary - Expand oxlint across workspaces/scripts with unused-directive checks and shard CI Vitest runs while preserving the required check context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui ontology querywith dash-prefixed names (Fixes ontology query treats a name that starts with dashes as an option #444): rescues a sole unknown boolean--<name>flag (e.g.ui ontology query --mu-surface/ui ontology query "--mu-surface") aspositionals[0]across both central CLI dispatch (src/cli.ts) andrunOntologyQuery(src/commands/ontology-query.ts), while keeping--dir,--area,--budget,--jsonworking and rejecting unknown flags alongside positionals or values.ui ingest-css-dson empty inputs (Fixes ingest-css-ds: an input with no custom property exits 0 and names a next step that fails #434): fails closed (exit 1,NO_TOKENS_WRITTEN) without writing an emptytokens.jsonwhencustomPropertiesis empty, pointing directly to checking--cssonui designmd extract-tokens.package.jsonbin.ui(Fixes npm publish warns that bin[ui] was invalid and removed #448): normalizes"./dist/cli.js"to"dist/cli.js", eliminating npm's publish-time warning while keepingnpm pack/ consumer bin linking intact.src/core/rendered/browser-session.tsnow checkschild.signalCode !== nullalongsidechild.exitCode !== nullsoSIGABRTcrashes fail immediately instead of stalling for the 20s debugger timeout.tests/rendered-tier.test.tsanda11y/tests/has-chrome.tsverify real headless launchability so restricted container environments skip cleanly whileubuntu-latestCI runs the live browser suites as before.orphantemp root intests/memory-autorecord.test.tswith.gitso$TMPDIRancestry cannot leak adesign/directory, and sets an explicit30_000mstimeout on the 20,000-deep stack-safety test intests/taste-checks-invisible-surface-edge-cases.test.ts.declarationMapandisolatedDeclarationsintsconfig.dts.jsonacross theease-design/lintboundary and asserts.d.ts.mapemission intests/lint-package-types.test.ts.oxlintgate & parallelized CI shards: expandsnpm run linttoa11y/,recall/, andscripts/with--deny-warnings --report-unused-disable-directives, and splits Vitest across two parallel shards (gates-and-shard-1andtest-shard-2) aggregated under the requiredcheckstatus context.