Skip to content

fix: harden CLI UX, browser crash handling, isolated declarations, and CI sharding - #455

Merged
jangtrinh merged 1 commit into
mainfrom
feat/ux-hardening-and-ds-surface
Nov 16, 2026
Merged

jangtrinh merged 1 commit into
mainfrom
feat/ux-hardening-and-ds-surface

Conversation

@jangtrinh

Copy link
Copy Markdown
Owner

Summary

  • CLI UX — ui ontology query with dash-prefixed names (Fixes ontology query treats a name that starts with dashes as an option #444): rescues a sole unknown boolean --<name> flag (e.g. ui ontology query --mu-surface / ui ontology query "--mu-surface") as positionals[0] across both central CLI dispatch (src/cli.ts) and runOntologyQuery (src/commands/ontology-query.ts), while keeping --dir, --area, --budget, --json working and rejecting unknown flags alongside positionals or values.
  • CLI UX — ui ingest-css-ds on empty inputs (Fixes ingest-css-ds: an input with no custom property exits 0 and names a next step that fails #434): fails closed (exit 1, NO_TOKENS_WRITTEN) without writing an empty tokens.json when customProperties is empty, pointing directly to checking --css on ui designmd extract-tokens.
  • Packaging — package.json bin.ui (Fixes npm publish warns that bin[ui] was invalid and removed #448): normalizes "./dist/cli.js" to "dist/cli.js", eliminating npm's publish-time warning while keeping npm pack / consumer bin linking intact.
  • Headless browser crash resilience & container self-skip probes:
    • src/core/rendered/browser-session.ts now checks child.signalCode !== null alongside child.exitCode !== null so SIGABRT crashes fail immediately instead of stalling for the 20s debugger timeout.
    • tests/rendered-tier.test.ts and a11y/tests/has-chrome.ts verify real headless launchability so restricted container environments skip cleanly while ubuntu-latest CI runs the live browser suites as before.
  • Test isolation & CPU-contention stability (Fixes memory-autorecord test fails when the temp directory has a design/ ancestor #447): bounds the orphan temp root in tests/memory-autorecord.test.ts with .git so $TMPDIR ancestry cannot leak a design/ directory, and sets an explicit 30_000ms timeout on the 20,000-deep stack-safety test in tests/taste-checks-invisible-surface-edge-cases.test.ts.
  • TypeScript 7 public declaration hardening: enables declarationMap and isolatedDeclarations in tsconfig.dts.json across the ease-design/lint boundary and asserts .d.ts.map emission in tests/lint-package-types.test.ts.
  • Workspace-wide oxlint gate & parallelized CI shards: expands npm run lint to a11y/, recall/, and scripts/ with --deny-warnings --report-unused-disable-directives, and splits Vitest across two parallel shards (gates-and-shard-1 and test-shard-2) aggregated under the required check status context.

…d CI sharding

Fixes #434
Fixes #444
Fixes #447
Fixes #448

- Rescue sole dash-prefixed query terms (e.g. --mu-surface) in ontology query while preserving flag validation
- Fail closed in ingest-css-ds when customProperties is empty and point to --css on designmd extract-tokens
- Normalize package.json bin.ui path to dist/cli.js to eliminate npm publish sanitization warnings
- Detect signal exits (child.signalCode) immediately in rendered browser-session and probe headless launchability in rendered-tier and a11y tests
- Bound memory-autorecord orphan test with .git and extend stack-safety test timeout for 2-vCPU CI runners
- Enable declarationMap and isolatedDeclarations in tsconfig.dts.json across the ease-design/lint boundary
- Expand oxlint across workspaces/scripts with unused-directive checks and shard CI Vitest runs while preserving the required check context
@jangtrinh
jangtrinh merged commit d583b77 into main Nov 16, 2026
6 checks passed
@jangtrinh
jangtrinh deleted the feat/ux-hardening-and-ds-surface branch November 16, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant