Fix cs md strlen overrun - #168
Open
PPSherry wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimap2 C code calls
strlen()on the seq pointer as the first operation inmm_gen_cs_or_MD(). Rust &[u8] slices are not NUL-terminated, so passingseq.as_ptr()directly causes __strlen_avx2 SIMD reads to walk past thebuffer into unmapped pages, triggering SIGSEGV (error 4).
Fix: build a NUL-terminated copy (seq_nul) once per read in the cs||md block and pass seq_nul_ptr to all mm_gen_cs/mm_gen_MD calls.
Also remove redundant CStr::from_ptr(contig.as_ptr()) that re-strlen an already-known-length CStr.
Tested on long-read scNanoATAC-seq data (13.8M reads, exit 0).