Skip to content

Added all changes from makerworld - #2

Open
SeanLovesCats wants to merge 2 commits into
jpypi:masterfrom
SeanLovesCats:master
Open

Added all changes from makerworld#2
SeanLovesCats wants to merge 2 commits into
jpypi:masterfrom
SeanLovesCats:master

Conversation

@SeanLovesCats

Copy link
Copy Markdown

All the changes from makerworld added here, it fixes the tabs that float in space and it has quite a few other fixes and useful settings.

Please let me know if there's any changes to the settings or otherwise you'd like me to make.

Thanks!

@silversword411

Copy link
Copy Markdown

The problem is TooManyThings changed the license at some point (not sure when) so not sure how many of the new changes you copy/pasted in this PR have copyright issues.

That the original design is MIT here https://makerworld.com/en/models/476846-gridfinity-parametric-base-plate#profileId-387853 means that we need to continue modifications and updates from that open source and move forward from there.

We should reach out to LayerCake the original designer and see if we can collab moving forward.

@jpypi

jpypi commented Jun 26, 2025

Copy link
Copy Markdown
Owner

Unfortunately @silversword411 is correct, which is why I haven't merged this. (Even though I'd love to!)

Do you have contact info for LayeredCake/where does that name come from? I wasn't aware of that individual. If we can we should absolutely reach out.

@silversword411

silversword411 commented Jun 26, 2025

Copy link
Copy Markdown

It's in the comment header of the file, I sent a message thru makerworld already.

And looks like they replied.

"Hi, I decided to keep it simple with my model it's a single purpose configurator, I don't really plan on adding to it unless someone finds a bug or something like that."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants