Fix build on Clang/ARM (r161757). - #2
Open
pliard-chromium wants to merge 1 commit into
Open
Conversation
Author
|
Hi Jeff, Can you please take a look at this patch? We had to fix this in Chromium when we rolled a new version of Clang. It would be great if we could get that in so that we don't differ too much in Chromium from upstream qcms. Thanks, |
Owner
|
Yeah. I'll try to get to this today. |
Author
|
Thanks Jeff! The patch has changed slightly while it was being reviewed in Chromium (mostly nits in comments). I'm not familiar with GitHub, should I close this pull request and create a new one or can I iterate on it (by adding a new commit and then squash the two commits together)? |
Owner
|
A new pull request is probably easier |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.