config: name storage volumes explicitly - #205
Merged
Merged
Conversation
Replace the unshipped storage.disks surface with storage.volumes and require byVolumeName: true for convention-derived partition selection. Keep the compiler output stable while making schema, validation, inspection, layering, and operator documentation reflect the public intent.
Zariel
enabled auto-merge (squash)
August 5, 2026 22:47
Greptile SummaryThe PR renames the unshipped public storage collection from
Confidence Score: 5/5The PR appears safe to merge; no concrete changed-code-triggered defects remain in the reviewed storage parsing, layering, validation, schema, or inspection paths. The renamed field and explicit partition selector are consistently propagated, selector-kind transitions discard incompatible inherited state, and effective volumes are validated before compilation or inspection.
|
| Filename | Overview |
|---|---|
| internal/installer/configbundle/bundle.go | Renames the public storage collection and adds the explicit convention-based partition selector to source configuration types. |
| internal/installer/configbundle/source_layering.go | Implements field-level volume inheritance, selector-kind replacement, presence-aware overrides, and validation for byVolumeName. |
| internal/installer/configbundle/schema_rules.go | Updates generated schema descriptions and requires byVolumeName to be explicitly true when selected. |
| internal/installer/configbundle/inspect.go | Reports effective public selectors, provenance, and convention-derived partition labels and mount sources. |
| internal/installer/configbundle/source_errors.go | Translates internal storage diagnostic paths to the renamed public storage.volumes contract. |
| docs/internal/cluster-manifest-contract.md | Documents the renamed storage shape and its deliberate field-level layering semantics. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[ClusterConfig storage.volumes] --> B[Strict source decoding]
B --> C[Defaults and node field-level layering]
C --> D[Effective-volume validation]
D --> E[Manifest storage target]
D --> F[Resolved public selector]
F --> G[Derived mount path and partition label]
E --> H[Install and runtime reconciliation]
Reviews (1): Last reviewed commit: "config: name storage volumes explicitly" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
storage.disksfield tostorage.volumespartition.byVolumeName: truefor convention-labelled partitionsWhy
Storage entries may be whole-disk or partition-backed, and the previous name and empty-object convention hid that distinction. The new source shape reads naturally and makes target selection visible to editors and operators without changing compiled runtime semantics.
The persistent
katldevjourney validated, resolved, applied, and reapplied the new shape against the preserved XFS data volume; the old spelling was refused and the existing filesystem identities and marker remained intact.