Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where a trailing slash in the server URL would break navidrome connections and require a reinstall.
Problem
On login, if the server URL was saved with a trailing slash (e.g. https://host.ts.net/), each request would be built as
https://host.ts.net//api/.... Navidrome would then route the//path to/app/causing login to fail.Since
//auth/loginis redirected to/app/,verifyNDSession()accepts the 200 as a valid session and the app doesn't prompt the user to log in again. This makes it so that re-entering the URL without the trailing slash doesn't fix the issue becauselogin()prefers the saved URL. The only workaround was reinstalling as far as I could figure out.Fix
Added a
normalizedServerURLfunction that trims the whitespace and trailing slashes and applies it when reading and writingserverBaseURLand to the typed URL inAuthService.login()I tested manually on Navidrome 0.60.3 behind Tailscale Serve, on iOS 27.2 (XCode iPhone 18 Pro Max Simulator). Haven't checked if subpaths such as
https://host/navidromeworks.