Support EC in PEM/DER utils. - #38483
Conversation
This change adds - Support for decoding EC private keys. - Support for decoding certificate bundles. Signed-off-by: Tero Saarni <tero.saarni@est.tech>
|
Thank you for this pull request. I see you linked it to the JGroups issue. Can please describe more about the scenario you are using it in, and what is now working what wasn't working before? |
|
Hi @ahus1, Currently nothing in upstream Keycloak requires this, but in the JGroups issue, you discuss a use case for EC. In my case, I've used this in a Keycloak fork to support SASL EXTERNAL client certificate authentication for LDAP federation (related to #7365 and keycloak/keycloak-community#345). That code has been evolving in our repository since then, but I'd be very interested in upstreaming even a small parts like this of that work if accepted. |
|
@tsaarni - thank you for the explanation. I'd be happy to review and merge it, still it would need a separate enhancement issue where you link it to, probably copying your previous comment and describing when and where it is useful. From the description above, it is IMHO not related to the JGroups issue. I'll then review it probably next week. |
|
Thank you @ahus1! I've now done that and fixed the issue reference in the description.
My thought was that if support for EC is being implemented in #37786, this enhancement would be necessary, as the current utils cannot decode EC private keys. |
This PR suggests small improvement to PEM/DER utilities:
Closes #38490