null or empty description no longer duplicates allowed fields - #50861
Open
edewit wants to merge 2 commits into
Open
null or empty description no longer duplicates allowed fields#50861edewit wants to merge 2 commits into
edewit wants to merge 2 commits into
Conversation
fixes: keycloak#50860 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
rest/admin-v2/services/src/test/java/org/keycloak/admin/internal/openapi/OpenApiSortParameterTest.java:159
- These tests rely on reflective access to a private method (
OASModelFilter.enhanceSortParameterDescription) and a specific field name (ListOptions.sort), which makes them brittle to innocuous refactors (renames/visibility changes) and can be problematic under stricter reflective access. Prefer testing via public behavior (e.g., asserting on the generated OpenAPI output for a representative endpoint), or make the helper logic package-private and explicitly testable (e.g.,@VisibleForTesting) to avoidsetAccessible(true).
private static String enhanceSortParameterDescription(String description) throws Exception {
Method method = OASModelFilter.class.getDeclaredMethod("enhanceSortParameterDescription", String.class, String.class);
method.setAccessible(true);
return (String) method.invoke(null, description, ClientField.allowedApiNames());
}
private static String listOptionsSortDescription() throws Exception {
Field sortField = ListOptions.class.getDeclaredField("sort");
Parameter parameter = sortField.getAnnotation(Parameter.class);
assertNotNull(parameter, "sort query parameter in ListOptions must declare @Parameter");
return parameter.description();
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #50860
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com