-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Add client type support to Admin API v2 #50895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnabnandy7
wants to merge
14
commits into
keycloak:main
Choose a base branch
from
arnabnandy7:feature/v2-client-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bca54a1
Add client type support to Admin API v2
arnabnandy7 ac125ef
Apply suggestions from code review
arnabnandy7 b3f3ea1
Reset explicit field tracking after model mapping
arnabnandy7 2282a50
Preserve client type policy and error details
arnabnandy7 4809ac1
Potential fix for pull request finding
arnabnandy7 357e649
Potential fix for pull request finding
arnabnandy7 36e6a7c
Potential fix for pull request finding
arnabnandy7 bc55ff4
Preserve client type in update policy context
arnabnandy7 52828ca
Merge remote-tracking branch 'upstream/main' into feature/v2-client-t…
arnabnandy7 be26a2c
Merge branch 'main' into feature/v2-client-types
arnabnandy7 fc81a49
Address client type review feedback
arnabnandy7 446a346
Address remaining client type review feedback
arnabnandy7 1432e45
Preserve typed SAML logout policy context
arnabnandy7 99d1755
Initialize omitted typed client authentication
arnabnandy7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
rest/admin-v2/services/src/main/java/org/keycloak/models/mapper/ClientModelMapper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,15 @@ | ||
| package org.keycloak.models.mapper; | ||
|
|
||
| import java.util.Set; | ||
|
|
||
| import org.keycloak.models.ClientModel; | ||
| import org.keycloak.representations.admin.v2.BaseClientRepresentation; | ||
|
|
||
| /** | ||
| * @author Vaclav Muzikar <vmuzikar@redhat.com> | ||
| */ | ||
| public interface ClientModelMapper extends RepModelMapper<BaseClientRepresentation, ClientModel> { | ||
| default void toModel(BaseClientRepresentation rep, ClientModel model, Set<String> excludedFields) { | ||
| toModel(rep, model); | ||
| } | ||
| } | ||
|
arnabnandy7 marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.