Cache the maven wrapper when building on GHI - #51445
Open
ahus1 wants to merge 1 commit into
Open
Conversation
ahus1
force-pushed
the
is-51444-cache-maven-wrapper
branch
3 times, most recently
from
August 5, 2026 06:24
59c39f8 to
3879563
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Caches Maven wrapper distributions to reduce CI download failures.
Changes:
- Adds Maven wrapper distributions to the OS-specific Maven cache.
- Enables Windows cache creation and removes cross-OS restoration.
- Adds batch mode to Windows-capable Quarkus unit tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Documents Windows wrapper behavior and adds Maven batch mode. |
.github/actions/maven-cache/action.yml |
Caches Maven wrapper distributions using OS-specific keys. |
Suppressed comments (1)
.github/actions/maven-cache/action.yml:35
- Include the wrapper properties hash in this key. Because caches are immutable, changing
distributionUrlduring the same weekly window still hits the old cache and prevents the newly downloaded Maven distribution from being saved, so every job must download it again and can reproduce the failure this change targets.
key: mvn-and-wrapper-${{ runner.os }}-${{ steps.weekly-cache-key.outputs.key }}
Member
Author
|
@Pepo48 - I hope this additional caching and cleanup makes this more robust. Please let me know if you agree with this approach. Thanks! |
ahus1
force-pushed
the
is-51444-cache-maven-wrapper
branch
from
August 6, 2026 00:29
3879563 to
d8c35b7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/actions/maven-cache/action.yml:48
- The comment above this restore path still says the hybrid cache strategy is used, although this step now restores only the exact OS-specific key. Please align the comment with the new behavior.
key: mvn-and-wrapper-${{ runner.os }}-${{ steps.weekly-cache-key.outputs.key }}
.github/actions/maven-cache/action.yml:30
- The adjacent comment still describes a hybrid cross-OS fallback, but this key is now OS-specific and the fallback settings were removed. Update it to avoid documenting behavior that no longer exists.
This issue also appears on line 48 of the same file.
key: mvn-and-wrapper-${{ runner.os }}-${{ steps.weekly-cache-key.outputs.key }}
Closes keycloak#51444 Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
ahus1
force-pushed
the
is-51444-cache-maven-wrapper
branch
from
August 6, 2026 01:16
d8c35b7 to
6b387a6
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#timeout |
vmuzikar
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51444
This also removes the cross-OS settings, as the archive is now OS specific