Skip to content

fix: correcting the query param name - #51457

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss51449
Aug 7, 2026
Merged

fix: correcting the query param name#51457
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss51449

Conversation

@shawkins

@shawkins shawkins commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

closes: #51449

We could consider checking in the generated openapi doc, similar to the client v2 logic, to make detection of things like this better.

closes: keycloak#51449

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Copilot AI balanced review requested due to automatic review settings August 5, 2026 12:50
@shawkins
shawkins requested a review from a team as a code owner August 5, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects role-group pagination so the REST endpoint and OpenAPI definition expose the max query parameter properly.

Changes:

  • Renames the malformed query parameter to max.
  • Applies the standard default maximum result count.

public Stream<GroupRepresentation> getGroupsInRole(final @Parameter(description = "the role name.") @PathParam("role-name") String roleName,
@Parameter(description = "First result to return. Ignored if negative or {@code null}.") @QueryParam("first") Integer firstResult,
@Parameter(description = "Maximum number of results to return. Unbounded if negative.") @QueryParam(Constants.DEFAULT_MAX_RESULTS_STR) Integer maxResults,
@Parameter(description = "Maximum number of results to return. Unbounded if negative.") @QueryParam("max") @DefaultValue(Constants.DEFAULT_MAX_RESULTS_STR) Integer maxResults,
@vmuzikar
vmuzikar merged commit 8996c5e into keycloak:main Aug 7, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect query parameter name for "max"

3 participants