Invalid redirect URI on logout from pages with sub-tab hash fragments - #51055
Merged
Conversation
Closes keycloak#51054 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces nested hash navigation with a query parameter to prevent invalid logout redirect URIs.
Changes:
- Passes the policy sub-tab through
?tab=. - Initializes the active policy tab from search parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
LoginTab.tsx |
Updates the passkeys settings shortcut URL. |
Policies.tsx |
Reads policy selection from query parameters. |
| tab: "policies", | ||
| }), | ||
| hash: WEBAUTHN_PASSWORDLESS_POLICY, | ||
| search: `?tab=${WEBAUTHN_PASSWORDLESS_POLICY}`, |
edewit
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behavior
Screencast.From.2026-07-21.09-41-30.mp4
New behavior
Screencast.From.2026-07-21.09-40-31.mp4
@edewit Could you please check it? Thanks!