Migrate ClientSecretRotationTest to the new CI - #51081
Merged
Merged
Conversation
Closes keycloak#50886 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates ClientSecretRotationTest to the new test framework and CI infrastructure.
Changes:
- Reworks test setup using managed realms, OAuth clients, events, and time offsets.
- Adds a builder helper for client access-type policy conditions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/client/ClientSecretRotationTest.java |
Migrates the client secret rotation integration tests. |
test-framework/builders/src/main/java/org/keycloak/testframework/realm/ClientPolicyBuilder.java |
Adds client access-type condition configuration support. |
Member
@rmartinc The remaining issues should be more-or-less fixed. It'd be nice, if @vaceksimon could review this one as well. Thanks! |
vaceksimon
approved these changes
Jul 22, 2026
vaceksimon
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good to me!
ahus1
enabled auto-merge (squash)
July 27, 2026 11:51
ahus1
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50886
Migration of the
ClientSecretRotationTestto the new CI. @mabartos take a look when you have time. See if it's a good time or you prefer to wait to have all the remaining issues fixed.