fix: allows verify email working in incognito browser tab after Keycloak restart - #51089
Merged
Merged
Conversation
pchorus
force-pushed
the
feature/fix-verify-email
branch
from
July 22, 2026 12:10
1a8fcce to
f84de65
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
services/src/main/java/org/keycloak/authentication/actiontoken/verifyemail/VerifyEmailActionTokenHandler.java:142
- Please add a regression test for the missing-root-session path. The existing
RequiredActionEmailVerificationTest.verifyEmailRegisterWithSecondBrowserkeeps the original root authentication session alive, so it would not catch this NPE returning after a restart; the test should remove/expire that session before opening the email link in the second browser and assert successful verification.
if (rootAuthSession != null) {
session.authenticationSessions().removeRootAuthenticationSession(realm, rootAuthSession);
}
2 tasks
pchorus
force-pushed
the
feature/fix-verify-email
branch
from
July 24, 2026 06:10
f84de65 to
a9ff644
Compare
pchorus
force-pushed
the
feature/fix-verify-email
branch
from
July 27, 2026 08:59
a9ff644 to
1ec54bf
Compare
Contributor
Author
pchorus
force-pushed
the
feature/fix-verify-email
branch
from
July 27, 2026 09:01
1ec54bf to
40d88cf
Compare
…oak restart closes keycloak#51088. Signed-off-by: Pascal Chorus <pascal.chorus@moneymeets.com>
rmartinc
force-pushed
the
feature/fix-verify-email
branch
from
July 27, 2026 15:45
40d88cf to
1766437
Compare
Contributor
| * in-memory authentication sessions that happens when Keycloak is restarted. | ||
| */ | ||
| private void removeRootAuthenticationSession() { | ||
| String encodedAuthSessionId = driver.driver().manage().getCookieNamed(CookieType.AUTH_SESSION_ID.getName()).getValue(); |
Comment on lines
+414
to
+415
| MimeMessage message = mailServer.getReceivedMessages()[0]; | ||
| String link = MailUtils.getPasswordResetEmailLink(message); |
Comment on lines
+140
to
+142
| if (rootAuthSession != null) { | ||
| session.authenticationSessions().removeRootAuthenticationSession(realm, rootAuthSession); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid
NullPointerException.Closes #51088.