[CVE-2026-16108] Realm default-group reads disclose hidden groups und… - #51090
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CVE-2026-16108 by preventing delegated administrators from discovering default groups they cannot view.
Changes:
- Filters default groups using FGAP group-view permissions.
- Applies filtering to realm details, realm listings, and the default-groups endpoint.
- Adds integration coverage for denied and granted access.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
RealmAdminResource.java |
Filters default groups in realm details and endpoint responses. |
RealmsAdminResource.java |
Filters default groups in realm listings. |
GroupResourceTypeFilteringTest.java |
Tests hidden and explicitly permitted default groups. |
sguilhen
approved these changes
Jul 22, 2026
pedroigor
approved these changes
Jul 27, 2026
pedroigor
approved these changes
Jul 27, 2026
pedroigor
left a comment
Contributor
There was a problem hiding this comment.
The only concern I have is that we are building group paths twice. We can improve that as a follow-up.
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.oauth.ClientAuthPostMethodTest#testPostAuthenticationNotAllowedWhenBasicRequestedorg.keycloak.testsuite.oauth.ClientAuthPostMethodTest#testBasicAuthenticationNotAllowedWhenPostRequested |
…er FGAP v2 Closes keycloak#51001 Signed-off-by: Martin Kanis <mkanis@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er FGAP v2
Closes #51001