make multi value toggle less confusing - #51110
Open
edewit wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns multivalued user-profile field rendering across React and FreeMarker UIs.
Changes:
- Prioritizes dedicated
inputTypecontrols over generic multi-input rendering. - Adds FreeMarker multivalue inference and Playwright coverage.
- Clarifies the Admin UI help text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
themes/src/main/resources/theme/base/login/user-profile-commons.ftl |
Adds inferred multivalue fallback. |
js/libs/ui-shared/src/user-profile/UserProfileFields.tsx |
Implements dedicated-control precedence. |
js/apps/admin-ui/test/realm-settings/userprofile.spec.ts |
Tests toggle persistence and checkbox rendering. |
js/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties |
Updates multivalued help text. |
Align multivalued rendering precedence across user profile UIs Ensure inputType-specific controls (select, multiselect, select-radiobuttons, multiselect-checkboxes, textarea) take precedence over generic multi-input rendering in React, and mirror the same fallback behavior in FreeMarker when inputType is unset. Clarify the Multivalued help text in Admin UI and update the user profile Playwright spec to assert the new precedence rules. fixes: keycloak#34763 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
force-pushed
the
multi-value-toggle
branch
from
July 27, 2026 06:16
69ab09c to
7265fe7
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabledKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabledKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align multivalued rendering precedence across user profile UIs
Ensure inputType-specific controls (select, multiselect,
select-radiobuttons, multiselect-checkboxes, textarea) take precedence
over generic multi-input rendering in React, and mirror the same
fallback behavior in FreeMarker when inputType is unset. Clarify the
Multivalued help text in Admin UI and update the user profile Playwright
spec to assert the new precedence rules.
fixes: #34763
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com