Gracefully handle disabled or removed IdP during logout#51163
Open
andrew2k4 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Allows local browser logout to complete when the originating identity provider is disabled or removed.
Changes:
- Handles unavailable identity providers during browser logout.
- Adds disabled and removed IdP logout tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
AuthenticationManager.java |
Skips unavailable broker logout and continues locally. |
KcOidcBrokerLogoutTest.java |
Adds regression scenarios, but currently exercises backchannel logout. |
andrew2k4
force-pushed
the
fix/51123-idp-logout
branch
from
July 25, 2026 17:35
b00051b to
7c292df
Compare
andrew2k4
force-pushed
the
fix/51123-idp-logout
branch
from
July 25, 2026 17:40
7c292df to
5d1d34d
Compare
When a user logs in through an identity provider and that provider is later disabled or deleted, browserLogout throws an IdentityBrokerException that breaks the entire logout flow. This wraps the identity provider lookup in a try-catch so that the logout completes locally even when the broker is no longer available, logging a warning instead of failing. Closes keycloak#51123 Signed-off-by: andrew <nguemnangandrew@gmail.com>
andrew2k4
force-pushed
the
fix/51123-idp-logout
branch
from
July 25, 2026 17:45
5d1d34d to
a2c6752
Compare
Comment on lines
+293
to
+294
| @Test | ||
| public void logoutSucceedsWhenIdpIsDisabled() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user logs in through an identity provider and that provider is later disabled or deleted, browserLogout throws an IdentityBrokerException that breaks the entire logout flow.
This wraps the identity provider lookup in a try-catch so that the logout completes locally even when the broker is no longer available, logging a warning instead of failing.
Closes #51123