fix(workflows): Fix WebAuthn IT workflow never runs in CI #51164#51165
Open
mbijon wants to merge 1 commit into
Open
fix(workflows): Fix WebAuthn IT workflow never runs in CI #51164#51165mbijon wants to merge 1 commit into
mbijon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blast Radius!
This is a two-line change, but it re-enables a suite that has not run in ~2 years.
Please expect genuine failures on the first runs that trigger it, and consider
whether they should be triaged before or after merge.
Problem
The
webauthn-integration-testsjob has been unconditionally skipped since2024-05-31. Its guard reads:
conditionalis not listed inneeds, soneeds.conditional.outputs.ci-webauthnresolves to an empty string and the condition is never true.
Fix
Add
conditionalto the job'sneedsso the guard expression can resolve: