User partial filters ignore ancestor group membership denies#51184
Open
vramik wants to merge 1 commit into
Open
User partial filters ignore ancestor group membership denies#51184vramik wants to merge 1 commit into
vramik wants to merge 1 commit into
Conversation
Closes keycloak#51158 Signed-off-by: vramik <vramik@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FGAP user filtering so parent-group permissions apply to descendant-group members.
Changes:
- Expands allowed and denied groups to descendant IDs.
- Adds a batched child-group query.
- Adds search, count, and direct-read denial regression coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
JpaUserPartialEvaluationProvider.java |
Expands group authorization filters to descendants. |
GroupEntity.java |
Adds the child-group lookup query. |
UserResourceTypeFilteringTest.java |
Tests denial inherited from a parent group. |
Comments suppressed due to low confidence (1)
model/jpa/src/main/java/org/keycloak/models/jpa/JpaUserPartialEvaluationProvider.java:187
- This traversal only reads
GroupEntity, so it misses descendants supplied by aGroupStorageProvider. Local JPA users can persist memberships to arbitrary provider group IDs, while direct authorization walksGroupModel.getParent(); consequently, denying an external parent still leaves members of its external child visible to search/count. Please traverse the provider-backed group hierarchy as well and cover that case.
List<String> children = em.createNamedQuery("getChildGroupIdsByParentIds", String.class)
.setParameter("realm", realmId)
.setParameter("parentIds", currentLevel)
.getResultList();
| } | ||
|
|
||
| return cb.exists(createUserMembershipSubquery(context, root -> root.get("groupId").in(allowedGroups))); | ||
| return cb.exists(createUserMembershipSubquery(context, root -> root.get("groupId").in(expandGroupsToDescendants(allowedGroups)))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51158