Partial evaluation misses ancestor group policies with extendChildren#51186
Open
vramik wants to merge 1 commit into
Open
Partial evaluation misses ancestor group policies with extendChildren#51186vramik wants to merge 1 commit into
vramik wants to merge 1 commit into
Conversation
Closes keycloak#51144 Signed-off-by: vramik <vramik@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FGAP partial evaluation for ancestor group policies using extendChildren.
Changes:
- Includes ancestor group IDs during policy discovery.
- Adds two- and three-level hierarchy regression tests for direct reads, search, and count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
GroupPolicyProvider.java |
Expands group-policy lookup to ancestor groups. |
UserResourceTypeFilteringTest.java |
Tests negative ancestor policies with extendChildren. |
Comment on lines
+116
to
+120
| List<String> groupIds = user.getGroupsStream() | ||
| .flatMap(group -> { | ||
| List<String> ids = new ArrayList<>(); | ||
| GroupModel current = group; | ||
| while (current != null) { |
Comment on lines
+115
to
+123
| // getParent() issues a query per ancestor; may need optimization for deep hierarchies | ||
| List<String> groupIds = user.getGroupsStream() | ||
| .flatMap(group -> { | ||
| List<String> ids = new ArrayList<>(); | ||
| GroupModel current = group; | ||
| while (current != null) { | ||
| ids.add(current.getId()); | ||
| current = current.getParent(); | ||
| } |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabledKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51144