Migrate Organization OIDC Mapper tests into new testsuite - #51196
Open
vramik wants to merge 1 commit into
Open
Conversation
Closes keycloak#51194 Signed-off-by: vramik <vramik@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates organization OIDC mapper tests to the new test framework and centralizes broker-login helpers.
Changes:
- Converts mapper tests to JUnit 5 and test-framework resources.
- Adds shared real-broker and login utilities.
- Updates existing member tests to use shared helpers.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
OrganizationMemberTest.java |
Uses centralized broker helpers. |
OrganizationOIDCProtocolMapperTest.java |
Migrates OIDC mapper coverage. |
OrganizationGroupOidcIdpMapperTest.java |
Migrates organization group IdP mapper tests. |
OrganizationGroupMembershipOIDCMapperTest.java |
Migrates group membership mapper tests. |
AbstractOrganizationTest.java |
Adds shared broker setup and login utilities. |
Comments suppressed due to low confidence (1)
tests/base/src/test/java/org/keycloak/tests/organization/mapper/OrganizationGroupMembershipOIDCMapperTest.java:71
@InjectOAuthClientcreates only the defaulttest-app, while every test in this class switches todirect-grant/password; the inherited realm configuration never creates that client. Provisiondirect-grantin the migrated realm setup or run these requests with a configured injected client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51194