Flush auto-created roles during user import to avoid duplicate role inserts in batch mode - #51210
Open
theohh0 wants to merge 2 commits into
Open
Flush auto-created roles during user import to avoid duplicate role inserts in batch mode#51210theohh0 wants to merge 2 commits into
theohh0 wants to merge 2 commits into
Conversation
Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
…x spotless Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents duplicate role inserts during batched realm user imports.
Changes:
- Flushes auto-created roles during batch imports.
- Reuses existing roles during role-definition import.
- Adds unit and integration regression coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
RepresentationToModel.java |
Adds role reuse and batch-aware flushing. |
DefaultExportImportManager.java |
Passes the session to role mapping creation. |
RepresentationToModelTest.java |
Tests reuse of existing client roles. |
RealmImportSharedUndefinedClientRoleTest.java |
Tests shared undefined client-role imports. |
sguilhen
approved these changes
Jul 28, 2026
sguilhen
left a comment
Contributor
There was a problem hiding this comment.
Looks ok to me - the license headers are not necessary but that a nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #50056 to fix #49731 and fixes failing checks (as requested by @sguilhen: #50056 (comment)) by:
RealmImportSharedUndefinedClientRoleTestfrom deprecated testsuite totests/base/src/test/java/org/keycloak/tests/exportimport/Note: I used IBM bob to fix some of the import requirements