Do not pass the client for Delegation parameterized scope type - #51254
Merged
Conversation
Closes issue-51253 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes delegation authorization under FGAPv2 by evaluating impersonation policies using the administrator identity.
Changes:
- Stops passing the client during delegation impersonation checks.
- Adds an integration test covering FGAPv2 delegation, refresh, exchange, and permission removal.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
services/.../DelegationScopeType.java |
Uses the correct impersonation evaluation context. |
tests/.../TokenExchangeDelegationTest.java |
Adds FGAPv2 delegation coverage. |
gaoyikeshuer
approved these changes
Jul 29, 2026
vaceksimon
approved these changes
Jul 29, 2026
ahus1
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51253
The PR removes passing the client for the
canImpersonatemethod. It seems that passing the client uses a special handling only used for Token Exchange V1 that uses the target user instead of the admin to evaluate the policies (which is very weird I must say). With this change the same behavior than in the normal impersonation in the user resource is used. Test added to use FGAP in the TE delegation test class.