Add briefRepresentation parameter for organization group-by-path endpoint - #51264
Open
kota65535 wants to merge 2 commits into
Open
Add briefRepresentation parameter for organization group-by-path endpoint#51264kota65535 wants to merge 2 commits into
kota65535 wants to merge 2 commits into
Conversation
…oint Signed-off-by: Tomohiko Ozawa <kota65535@gmail.com>
kota65535
force-pushed
the
worktree/molten-granite
branch
from
July 29, 2026 23:15
56209ce to
d986c03
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
services/src/main/java/org/keycloak/organization/admin/resource/OrganizationGroupsResource.java:240
- The default still selects the brief representation, so requests without the new query parameter—including the existing two-argument admin-client method—continue to omit attributes and role mappings. This contradicts the PR/issue requirement that group-by-path return a full representation by default; make the default
false(and update the parameter description).
@Parameter(description = "Whether to return a brief representation (default: true)") @QueryParam("briefRepresentation") @DefaultValue("true") boolean briefRepresentation,
services/src/main/java/org/keycloak/organization/admin/resource/OrganizationGroupsResource.java:250
- The new full/brief behavior is not covered by the existing organization group-by-path tests, which assert only name/path and would pass even when the default remains brief. Add coverage that verifies an omitted
briefRepresentationreturns attributes and role mappings, whilebriefRepresentation=trueomits them.
GroupRepresentation rep = briefRepresentation ?
ModelToRepresentation.groupToBriefRepresentation(found) :
ModelToRepresentation.toRepresentation(found, true);
2 tasks
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #51263