Generic identity-provider creation can bind brokers to organizations … - #51288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents generic identity-provider APIs from linking brokers to organizations without organization-management permission, addressing CVE-2026-18201.
Changes:
- Strips organization identifiers during generic IdP creation and update.
- Adds authorization regression coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
OrganizationAdminRolesPermissionsTest.java |
Tests unauthorized binding attempts. |
IdentityProvidersResource.java |
Secures generic IdP creation. |
IdentityProviderResource.java |
Secures generic IdP updates. |
Organizations.java |
Adds organization-ID stripping utility. |
Comment on lines
+203
to
+204
| // organization-related information should not be processed by non-organization API | ||
| Organizations.stripOrganizationId(providerRep); |
pedroigor
previously approved these changes
Jul 29, 2026
Contributor
|
@vramik The test failures seem related, and the cause is that some tests rely on the previous behavior. Instead, we should call the Organization API to bind the IdP to the organization. I can work on this, as you are not supposed to be here :) |
…without manage-organizations Closes keycloak#51283 Signed-off-by: vramik <vramik@redhat.com>
pedroigor
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…without manage-organizations
Closes #51283