[OID4VCI] Namespace credential offer cache entries with realm-scoped keys - #51307
Merged
Conversation
Closes keycloak#51198 Signed-off-by: Awambeng Rodrick <awambengrodrick@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Namespaces OID4VCI credential-offer cache entries by realm to prevent cross-realm collisions.
Changes:
- Adds realm-scoped
oid4vc_offer:cache keys for storage, retrieval, and removal. - Adds unit coverage for prefixed keys and storage behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
DefaultCredentialOfferStorage.java |
Builds and consistently applies realm-scoped cache keys. |
DefaultCredentialOfferStorageTest.java |
Tests prefixed storage, retrieval, removal, and expiration. |
mposolda
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents cross-realm cache collisions in
DefaultCredentialOfferStorageby namespacing single-use cache entries with a prefix and realm ID, following the same pattern used byParEndpoint.Key changes:
<offerId>tooid4vc_offer:<realmId>:<offerId>to prevent a credential offer created in one realm from being consumed in another realm when both have matching offer IDs.CACHE_KEY_PREFIXconstant and abuildCacheKeyhelper to derive the realm from the session context and centralize the realm binding logic.getOfferStateByNonceinherits the fix transparently since it resolves the offer ID and delegates togetOfferStateById.Closes #51198