Fix stateless cluster and db migrations race - #51357
Conversation
Signed-off-by: Sebastian Łaskawiec <sebastian.laskawiec@defenseunicorns.com>
18e45ce to
5398acc
Compare
ahus1
left a comment
There was a problem hiding this comment.
This looks good to me; please switch to "ready" once you're good with this change.
There was a problem hiding this comment.
🟢 Ready to approve
The lifecycle race is correctly addressed and covered by a focused regression test.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Fixes stateless startup during database migrations by avoiding factory lifecycle-dependent cluster state.
Changes:
- Resolves
NodeInfoand marshaller from the active session. - Adds regression coverage for provider use before
postInit().
File summaries
| File | Description |
|---|---|
DatabaseAwareClusterProviderFactory.java |
Removes prematurely captured factory state. |
DatabaseAwareClusterProviderFactoryTest.java |
Tests pre-postInit() event notification. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Thanks @ahus1 ! Ready for review/merge! |
|
@slaskawi - merged! Can you please provide a backport to 26.7? Thanks! |
Summary
This Pull Request fixes a race condition between triggering the migration and bootstrapping Infinispan cluster.
The race condition has been noticed in UDS Platform.
Related tickets
Closes #51154