Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cache-lifetime test still passes with the old three-day default because it checks caching immediately and then jumps beyond 30 days, missing the interval that distinguishes the defaults.
1 open issue
What changed in this PR
Aligns the Client ID Metadata Document cache ceiling with the intended 30-day default, addressing #51739.
Changes:
- Increases the default maximum cache time from 259200 seconds (3 days) to 2592000 seconds (30 days).
- Updates the cache-control test case and user guide to match.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/client/policies/ClientIdMetadataDocumentTest.java |
Updates the maximum-lifetime test input, expectation, and comments. |
services/src/main/java/org/keycloak/protocol/oauth2/cimd/clientpolicy/executor/ClientIdMetadataDocumentExecutorFactoryProviderConfig.java |
Sets the default cache ceiling to 30 days. |
docs/guides/securing-apps/mcp-authz-server.adoc |
Documents the new 30-day default. |
Review effort: Balanced
…0 days closes keycloak#51739 Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
tnorimat
force-pushed
the
ISSUE-51739
branch
from
November 17, 2026 09:35
593e151 to
cea2724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #51739