Skip to content

[CIMD] DEFAULT_CONFIG_MAX_CACHE_TIME is 3 days but is documented as 30 days - #54508

Open
tnorimat wants to merge 1 commit into
keycloak:mainfrom
Hitachi:ISSUE-51739
Open

tnorimat wants to merge 1 commit into
keycloak:mainfrom
Hitachi:ISSUE-51739

Conversation

@tnorimat

Copy link
Copy Markdown
Contributor

closes #51739

@tnorimat
tnorimat requested a review from a team as a code owner October 31, 2026 08:46
Copilot AI balanced review requested due to automatic review settings October 31, 2026 08:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The cache-lifetime test still passes with the old three-day default because it checks caching immediately and then jumps beyond 30 days, missing the interval that distinguishes the defaults.

1 open issue
What changed in this PR

Aligns the Client ID Metadata Document cache ceiling with the intended 30-day default, addressing #51739.

Changes:

  • Increases the default maximum cache time from 259200 seconds (3 days) to 2592000 seconds (30 days).
  • Updates the cache-control test case and user guide to match.
File Description
tests/​base/​src/​test/​java/​org/​keycloak/​tests/​client/​policies/​ClientIdMetadataDocumentTest.java Updates the maximum-lifetime test input, expectation, and comments.
services/​src/​main/​java/​org/​keycloak/​protocol/​oauth2/​cimd/​clientpolicy/​executor/​ClientIdMetadataDocumentExecutorFactoryProviderConfig.java Sets the default cache ceiling to 30 days.
docs/​guides/​securing-apps/​mcp-authz-server.adoc Documents the new 30-day default.

Review effort: Balanced

…0 days

closes keycloak#51739

Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 09:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the 30-day cache-ceiling update.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CIMD] DEFAULT_CONFIG_MAX_CACHE_TIME is 3 days but is documented as 30 days

2 participants