Skip to content

Add generated keys provider for ML-DSA - #55099

Open
stianst wants to merge 1 commit into
keycloak:mainfrom
stianst:ml-dsa
Open

stianst wants to merge 1 commit into
keycloak:mainfrom
stianst:ml-dsa

Conversation

@stianst

@stianst stianst commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Closes #44142

Signed-off-by: stianst stianst@gmail.com

@stianst
stianst requested a review from a team as a code owner November 12, 2026 11:35
Copilot AI balanced review requested due to automatic review settings November 12, 2026 11:35

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 11:53

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 12:01

This comment was marked as outdated.

@lhanusov lhanusov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst LGTM, thanks 👍

Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:18

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 13:52

This comment was marked as outdated.

keycloak-github-bot[bot]

This comment was marked as outdated.

@keycloak-github-bot

This comment was marked as off-topic.

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 09:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the experimental ML-DSA key-provider changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Closes keycloak#44142

Signed-off-by: stianst <stianst@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 10:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Component validation accepts mismatched ML-DSA-65 private and public keys, allowing a provider to produce signatures that cannot be verified with its published JWKS key.

1 open issue

Review effort: Balanced

X509EncodedKeySpec publicKeySpec = new X509EncodedKeySpec(Base64.getMimeDecoder().decode(publicMlDsaKeyBase64Encoded));
PublicKey decodedPublicKey = kf.generatePublic(publicKeySpec);

KeyPair keyPair = new KeyPair(decodedPublicKey, decodedPrivateKey);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generated keys provider for ML-DSA (OIDC)

3 participants