Repository navigation
Conversation
edewit
previously approved these changes
Nov 13, 2026
edewit
marked this pull request as ready for review
November 13, 2026 08:52
edewit
marked this pull request as draft
November 13, 2026 08:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change to display required actions as a numbered list.
No open issues 🎉
What changed in this PR
This PR improves the login info page by displaying required actions as a numbered list below the server message, addressing #55129.
Changes:
- Replaces inline, comma-separated actions with an ordered list.
- Uses the existing
kcStepListClasstheme property. - Renders the list only when required actions are present.
| File | Description |
|---|---|
themes/src/main/resources/theme/base/login/info.ftl |
Separates required actions from the message into a conditional numbered list. |
Review effort: Balanced
Closes keycloak#55129 Signed-off-by: kathari00 <katharina.eiserfey1@gmail.com>
kathari00
force-pushed
the
fix/info-required-actions-list
branch
from
November 15, 2026 21:34
2e32848 to
c44b45d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The info page can present several required actions after a successful update. A numbered list makes each next step easier to scan and keeps the server message separate from the actions.
This uses the existing
kcStepListClasstheme property, as other ordered lists in the base theme do. The list is rendered only when required actions are present.Closes #55129